Skip to content

Set march to haswell #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2020
Merged

Set march to haswell #192

merged 1 commit into from
Sep 17, 2020

Conversation

@gsvic
Copy link
Contributor

@gsvic gsvic commented Sep 15, 2020

No description provided.

@gsvic gsvic requested a review from Shelnutt2 September 15, 2020 13:38
@gsvic gsvic force-pushed the victorgiannakouris/change_march_to_haswell branch 2 times, most recently from 39bc07f to 42e966a Compare September 15, 2020 15:29
Shelnutt2
Shelnutt2 reviewed Sep 15, 2020
View reviewed changes
azure-pipelines.yml Outdated
imageName: 'ubuntu-16.04'
ORG_GRADLE_PROJECT_TILEDB_S3: "ON"
ORG_GRADLE_PROJECT_TILEDB_SERIALIZATION: "ON"
CFLAGS: "-march=core2 -mtune=haswell -mssse3"
Copy link
Member

@Shelnutt2 Shelnutt2 Sep 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do -march=haswell, even though we used -march=core2 previously, setting the minimum to AVX2 will provide a good level of performance. If we have a user who needs -march=core2 we can adjust, but lets aim for the performance benefits of AVX/AVX2.

Copy link
Contributor Author

@gsvic gsvic Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@gsvic gsvic force-pushed the victorgiannakouris/change_march_to_haswell branch from 42e966a to 8672b80 Compare September 17, 2020 11:00
@gsvic gsvic requested a review from Shelnutt2 September 17, 2020 11:00
@Shelnutt2 Shelnutt2 mentioned this pull request Sep 17, 2020
Merged
@gsvic gsvic force-pushed the victorgiannakouris/change_march_to_haswell branch 3 times, most recently from a3b7dd5 to 3baaf92 Compare September 17, 2020 15:56
@gsvic gsvic force-pushed the victorgiannakouris/change_march_to_haswell branch from 3baaf92 to b002d5b Compare September 17, 2020 16:17
@Shelnutt2 Shelnutt2 merged commit 1c21044 into master Sep 17, 2020
@Shelnutt2 Shelnutt2 deleted the victorgiannakouris/change_march_to_haswell branch September 17, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shelnutt2 Shelnutt2 Shelnutt2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gsvic @Shelnutt2